feat: add deepcopy implementation for BoundedAttributes#4934
Merged
lzchen merged 7 commits intoopen-telemetry:mainfrom Mar 13, 2026
Merged
feat: add deepcopy implementation for BoundedAttributes#4934lzchen merged 7 commits intoopen-telemetry:mainfrom
lzchen merged 7 commits intoopen-telemetry:mainfrom
Conversation
pmcollins
reviewed
Feb 25, 2026
Member
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
Looks like if you create a span via tracer.start_as_current_span(...), the _events member is set to a BoundedList, which apparently also has a lock that will prevent a deep copy.
herin049
force-pushed
the
feat/bounded-attr-deepcopy
branch
from
012a9c0 to
8d5e9a7
Compare
pmcollins
reviewed
Mar 10, 2026
herin049
force-pushed
the
feat/bounded-attr-deepcopy
branch
2 times, most recently
from
820251f to
9c918df
Compare
pmcollins
approved these changes
Mar 11, 2026
Member
pmcollins
left a comment
pmcollins
left a comment
There was a problem hiding this comment.
LGTM, thanks for the change.
lzchen
reviewed
Mar 11, 2026
lzchen
approved these changes
Mar 11, 2026
herin049
force-pushed
the
feat/bounded-attr-deepcopy
branch
2 times, most recently
from
c656d4b to
976b17a
Compare
herin049
moved this from Reviewed PRs that need fixes
to Approved PRs
in Python PR digest
herin049
force-pushed
the
feat/bounded-attr-deepcopy
branch
from
976b17a to
1ca84f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a custom
__deepcopy__implementation forBoundedAttributes.Fixes #4928
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: